Repository navigation
text: report byte offset in UnescapeError::BadEscape - #738
Open
Divyansh151005 wants to merge 1 commit into
Open
Divyansh151005 wants to merge 1 commit into
Divyansh151005 wants to merge 1 commit into
Conversation
Fixes anthropics#648 BadEscape is now { reason, offset } with offset in Display. TextDecoder adds the offset to the token start when mapping to ParseError so a bad escape in a later concatenated literal gets the correct line and column.
|
All contributors have signed the CLA ✍️ ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #648
What this does
UnescapeError::BadEscapebecomes{ reason, offset }(breaking API, as discussed on the issue).Displayincludes the byte offset into the literal token.TextDecoder::read_string/read_bytesadd that offset totok.posbefore computing line/column, so adjacent literals no longer report errors at the first quote.unescape_stron a two-literal token anddecode_from_stron the issue-shaped input.Testing
All passed locally.