Repository navigation
refactor(config): delegate Config.browserSortXX properties - #22651
Merged
david-allison merged 2 commits intoOct 21, 2026
Merged
Conversation
david-allison
force-pushed
the
libanki-config-browser-sorting
branch
from
October 20, 2026 19:39
a172532 to
9afb489
Compare
mikehardy
approved these changes
Oct 21, 2026
mikehardy
left a comment
Member
There was a problem hiding this comment.
Assisted-by: grok-4.7-medium
Thanks David — another tidy config delegate.
Prep rebased two commits onto main locally (not pushed). Lint/CQ, unit, and emulator on emulator-5554 / API36_GAPI_PS16K passed on LOCAL_TIP (known phone-AVD XML noise only). GitHub CI on 9afb4895 is green.
The four card-browser sort fields now use jsonConfigProperty with the same keys and defaults as the prior config.get / config.set paths; SortType.save still updates the matching pair in one withCol block.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 21, 2026
Also delegate Config.browserSortNotesColumn. Assisted-by: GPT-6-Astra xhigh
Also delegate Config.browserSortNotesBackwards. Assisted-by: GPT-6-Astra xhigh
david-allison
force-pushed
the
libanki-config-browser-sorting
branch
from
October 21, 2026 14:39
9afb489 to
bb65ba8
Compare
david-allison
enabled auto-merge
October 21, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: GPT-6-Astra xhigh
Purpose / Description
Kotlin delegated property syntax is MUCH nicer to use than the backend syntax, so use it
Approach
Configaccessors in:anki-common#22430How Has This Been Tested?
Checklist