Skip to content

refactor(config): delegate Config.browserSortXX properties - #22651

Merged
david-allison merged 2 commits into
ankidroid:mainfrom
david-allison:libanki-config-browser-sorting
Oct 21, 2026
Merged

david-allison merged 2 commits into
ankidroid:mainfrom
david-allison:libanki-config-browser-sorting

Conversation

@david-allison

Copy link
Copy Markdown
Member

Note

Assisted-by: GPT-6-Astra xhigh

Purpose / Description

Kotlin delegated property syntax is MUCH nicer to use than the backend syntax, so use it

Approach

How Has This Been Tested?

⚠️ Trivial refactors in well-tested code. Trivial test

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
david-allison force-pushed the libanki-config-browser-sorting branch from a172532 to 9afb489 Compare October 20, 2026 19:39

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assisted-by: grok-4.7-medium

Thanks David — another tidy config delegate.

Prep rebased two commits onto main locally (not pushed). Lint/CQ, unit, and emulator on emulator-5554 / API36_GAPI_PS16K passed on LOCAL_TIP (known phone-AVD XML noise only). GitHub CI on 9afb4895 is green.

The four card-browser sort fields now use jsonConfigProperty with the same keys and defaults as the prior config.get / config.set paths; SortType.save still updates the matching pair in one withCol block.

@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Oct 21, 2026
@mikehardy
mikehardy added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 21, 2026
Also delegate Config.browserSortNotesColumn.

Assisted-by: GPT-6-Astra xhigh
Also delegate Config.browserSortNotesBackwards.

Assisted-by: GPT-6-Astra xhigh
@david-allison
david-allison force-pushed the libanki-config-browser-sorting branch from 9afb489 to bb65ba8 Compare October 21, 2026 14:39
@david-allison
david-allison added this pull request to the merge queue Oct 21, 2026
Merged via the queue into ankidroid:main with commit e9a3602 Oct 21, 2026
23 of 25 checks passed
@david-allison
david-allison deleted the libanki-config-browser-sorting branch October 21, 2026 17:19
@github-actions github-actions Bot added this to the 2.26 release milestone Oct 21, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants