Skip to content

Tidy the Generate graph modal - #94

Merged
LaSav merged 4 commits into
mainfrom
ui/generate-modal-cleanup
Nov 17, 2026
Merged

LaSav merged 4 commits into
mainfrom
ui/generate-modal-cleanup

Conversation

@LaSav

@LaSav LaSav commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Modal panel: no border, corners rounded-lg → rounded
  • Removed the "Filter by" header row in the modal (new showHeader prop on FilterBar, default true, so Browse is unchanged)
  • Clear filters moved to the footer, left of Cancel; it still clears keywords and authors too, and is disabled when nothing is set
  • Match count is just "N papers match"; the "shown 500 at a time, newest first" note is dropped (the graph legend already says it)
  • Tag chips in the modal no longer show paper counts (showTagCounts={false}). The Pinned list's filter chips keep their counts on purpose

Test plan

  • tsc --noEmit clean
  • vitest run src/components: 29/29 pass
  • Visual check of the modal from Graph (Generate / Edit) and Browse (Create graph, which has the Name field)

🤖 Generated with Claude Code

Drop the modal's border and soften its corners, remove the "Filter by"
row and move Clear filters into the footer, drop the 500-per-page note
from the match count (the graph legend covers it), and hide per-tag
counts on the modal's chips.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@netlify

netlify Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for alignment-graph canceled.

Name Link
🔨 Latest commit 8316cca
🔍 Latest deploy log https://app.netlify.com/projects/alignment-graph/deploys/6afbaa78e782244550ed409c

@LaSav

LaSav commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

AI review: AI-CLEARED

Reviewed 546a1d0 against main.

Findings

No open findings. Two low-severity issues from earlier passes are fixed on this branch:

  • Fixed in e5838b9: Clear filters disables itself once clicked, which dropped focus to <body>, so Escape and Enter stopped reaching the dialog. It now hands focus back to the panel.
  • Fixed in 546a1d0: after that change, holding Enter on Clear filters let key-repeat reach the panel and generate a graph with the filters just cleared. The panel now ignores repeated Enter presses.

Each fix has a regression test, and each test fails without its fix. No risk paths triggered: the diff only touches two UI components and a test. FilterBar's new showHeader prop defaults to true, so both Browse panels are unchanged.

LaSav and others added 3 commits November 17, 2026 00:19
The button disables itself once filters are cleared, which dropped focus
to <body> and stopped Escape/Enter reaching the dialog.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Clear filters now hands focus back to the panel, so key-repeat from a
held Enter on it reached the panel and generated with cleared filters.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LaSav
LaSav merged commit b568563 into main Nov 17, 2026
7 checks passed
@LaSav
LaSav deleted the ui/generate-modal-cleanup branch November 17, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant