Repository navigation
Drop the zod 3.25.76 OSV allowlist entry - #149
Merged
Merged
Conversation
The x402 packages moved to zod 4 in 2.29.0, so no zod 3 copy remains in the lock (only zod 4.6.7) and the entry suppressed nothing. The scan is clean without it.
Contributor
Author
Review (head 7b78382)Verdict: approve. I checked each claim against the lock, the registry and the scanner, and all of them hold. I found no defects. Lift condition is met
Lock holds only zod 4.6.7
Scan is clean with and without the entry (osv-scanner 2.7.0)
The positive control shows the scanner does detect this advisory against this lock and config, so the clean result above is meaningful. Other checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
zod3.25.76 entry fromosv-scanner.toml. Its own lift condition ("Lift when the x402 packages accept zod 4") is met: the x402 packages depend on zod 4 from 2.29.0, and the lock now holds a single zod, 4.6.7. The entry matched nothing, so it was suppressing nothing. The file keeps its header so the scanner config stays in place.Worked with: Varun.
Not done: nothing else in the allowlist; this was its only entry.
Type of change
Public API
None.
Test plan
osv-scanner scan source --lockfile bun.lock --config osv-scanner.toml: 609 packages, no issues.Checklist