Summary
datamodel-code-generator is vulnerable to code injection when generating Python models from an attacker-controlled GraphQL schema. A description on a Union type, written in the regular-string form ("...") with a literal \r escape, is rendered into a Python # comment by a Jinja2 filter that handles only \n. Python's tokenizer treats a bare CR as a physical-line terminator, so the comment ends at the \r and the text after it is parsed as module-level Python. The injected code executes at import time of the generated .py, in the context of any consumer that imports the model. No special CLI flags are required.
This affects versions >=0.25.0, <0.60.1 and is fixed in 0.60.1.
Details
The vulnerable output was generated by the GraphQL Union templates:
src/datamodel_code_generator/model/template/UnionTypeStatement.jinja2src/datamodel_code_generator/model/template/UnionTypeAliasAnnotation.jinja2src/datamodel_code_generator/model/template/UnionTypeAliasType.jinja2
Before 0.60.1, Union descriptions were rendered as Python comments using logic equivalent to # {{ description | replace('\n', '\n# ') }}.
The Jinja2 replace filter handled \n, but bare \r was not normalized. Python's lexical analysis treats CR, LF, and CRLF as physical line terminators. As a result, a malicious GraphQL schema could cause the generated Python comment to end early and emit attacker-controlled text as module-level Python code.
The description value reaches Union generation from graphql-core through description=union_object.description. GraphQL regular string values can contain \r escapes, and graphql-core preserves that value. Block strings are not affected in the same way because their line endings are normalized before reaching code generation.
Impact
An attacker who can provide or influence a GraphQL schema processed by datamodel-code-generator could cause arbitrary Python code to be generated into the output file. That code would execute with the privileges of the process importing the generated model.
This can affect developers, CI pipelines, or applications that run datamodel-codegen --input-file-type graphql on untrusted or third-party GraphQL schemas and then import the generated Python module.
No custom templates, special CLI flags, or remote reference options are required.
Remediation
Upgrade to datamodel-code-generator 0.60.1 or later.
The fix normalizes carriage returns in GraphQL Union descriptions before rendering them as Python comments, so injected text remains inside the comment block.
Resolution
The fix applies comment_safe to GraphQL Union descriptions before template rendering. It normalizes CRLF and bare CR to LF so the existing Union comment templates keep the whole description inside the generated Python comment block.
Submitted by: Hamza Haroon (thegr1ffyn)
References
thegr1ffyn Reporter
Summary
datamodel-code-generatoris vulnerable to code injection when generating Python models from an attacker-controlled GraphQL schema. A description on a Union type, written in the regular-string form ("...") with a literal\rescape, is rendered into a Python#comment by a Jinja2 filter that handles only\n. Python's tokenizer treats a bare CR as a physical-line terminator, so the comment ends at the\rand the text after it is parsed as module-level Python. The injected code executes atimporttime of the generated.py, in the context of any consumer that imports the model. No special CLI flags are required.This affects versions
>=0.25.0, <0.60.1and is fixed in0.60.1.Details
The vulnerable output was generated by the GraphQL Union templates:
src/datamodel_code_generator/model/template/UnionTypeStatement.jinja2src/datamodel_code_generator/model/template/UnionTypeAliasAnnotation.jinja2src/datamodel_code_generator/model/template/UnionTypeAliasType.jinja2Before
0.60.1, Union descriptions were rendered as Python comments using logic equivalent to# {{ description | replace('\n', '\n# ') }}.The Jinja2
replacefilter handled\n, but bare\rwas not normalized. Python's lexical analysis treats CR, LF, and CRLF as physical line terminators. As a result, a malicious GraphQL schema could cause the generated Python comment to end early and emit attacker-controlled text as module-level Python code.The
descriptionvalue reaches Union generation fromgraphql-corethroughdescription=union_object.description. GraphQL regular string values can contain\rescapes, andgraphql-corepreserves that value. Block strings are not affected in the same way because their line endings are normalized before reaching code generation.Impact
An attacker who can provide or influence a GraphQL schema processed by
datamodel-code-generatorcould cause arbitrary Python code to be generated into the output file. That code would execute with the privileges of the process importing the generated model.This can affect developers, CI pipelines, or applications that run
datamodel-codegen --input-file-type graphqlon untrusted or third-party GraphQL schemas and then import the generated Python module.No custom templates, special CLI flags, or remote reference options are required.
Remediation
Upgrade to
datamodel-code-generator0.60.1or later.The fix normalizes carriage returns in GraphQL Union descriptions before rendering them as Python comments, so injected text remains inside the comment block.
Resolution
The fix applies
comment_safeto GraphQL Union descriptions before template rendering. It normalizes CRLF and bare CR to LF so the existing Union comment templates keep the whole description inside the generated Python comment block.Submitted by: Hamza Haroon (thegr1ffyn)
References