Summary
LocalFolderExtractor validates only the final canonical file path before extraction. However, makeFile() creates intermediate directories one path segment at a time without checking whether each created directory remains inside the destination folder.
A malicious RAR entry can make the final file path resolve inside the extraction destination, while causing intermediate mkdir() calls to create attacker-chosen directories outside the extraction root.
This is an extraction root escape via unchecked intermediate directory creation. The default impact is directory creation outside the intended destination, not unconditional arbitrary file content write.
Affected Code
src/main/java/com/github/junrar/LocalFolderExtractor.java
createFile() checks only the final canonical path.makeFile() calls dir.mkdir() for each intermediate segment without containment checks.
Relevant code flow:
private File createFile(final FileHeader fh, final File destination) throws IOException {
String name = invariantSeparatorsPathString(fh.getFileName());
File f = new File(destination, name);
String dirCanonPath = f.getCanonicalPath();
if (!dirCanonPath.startsWith(destination.getCanonicalPath() + File.separator)) {
throw new IllegalStateException(...);
}
if (!f.exists()) {
f = makeFile(destination, name);
}
return f;
}
private File makeFile(final File destination, final String name) throws IOException {
final String[] dirs = name.split("/");
String path = "";
for (int i = 0; i < dirs.length - 1; i++) {
path = path + File.separator + dirs[i];
File dir = new File(destination, path);
dir.mkdir();
}
path = path + File.separator + dirs[dirs.length - 1];
final File f = new File(destination, path);
f.createNewFile();
return f;
}Impact
An attacker who can supply a malicious RAR archive can create directories outside the intended extraction directory.
This violates the expected extraction boundary and can be used for filesystem pollution or file-vs-directory squatting. For example, an attacker can create a directory at a path where a later security-sensitive file is expected, causing future writes to that path to fail.
References
smaeljaish771 Reporter
KeenSecurityLab Sponsor
Summary
LocalFolderExtractorvalidates only the final canonical file path before extraction. However,makeFile()creates intermediate directories one path segment at a time without checking whether each created directory remains inside the destination folder.A malicious RAR entry can make the final file path resolve inside the extraction destination, while causing intermediate
mkdir()calls to create attacker-chosen directories outside the extraction root.This is an extraction root escape via unchecked intermediate directory creation. The default impact is directory creation outside the intended destination, not unconditional arbitrary file content write.
Affected Code
src/main/java/com/github/junrar/LocalFolderExtractor.javacreateFile()checks only the final canonical path.makeFile()callsdir.mkdir()for each intermediate segment without containment checks.Relevant code flow:
Impact
An attacker who can supply a malicious RAR archive can create directories outside the intended extraction directory.
This violates the expected extraction boundary and can be used for filesystem pollution or file-vs-directory squatting. For example, an attacker can create a directory at a path where a later security-sensitive file is expected, causing future writes to that path to fail.
References