Repository navigation
test: run the wasm2c spec tests with memory64 on Windows - #2905
Merged
Merged
Conversation
sbc100
marked this pull request as ready for review
October 22, 2026 20:33
sbc100
enabled auto-merge (squash)
October 22, 2026 20:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run-spec-wasm2c.pyskips a test on Windows when memory64 is enabled. That skip was writtenwhen memory64 was opt-in (
--enable-memory64, #2086). Since #2837 memory64 is on by default(
--disable-memory64), so the condition holds for almost every test and 260 of the 262 wasm2ctests are skipped on
windows-latest: the C that wasm2c writes is not compiled by cl.exe.This removes the skip. Split out of #2901 at @sbc100's request.