Skip to content

chore(ci): unblock Rust 1.100 clippy, Windows sccache limit, and RUSTSEC-2026-0543 - #317

Merged
lemon07r merged 2 commits into
masterfrom
chore/chrono-advisory
Nov 18, 2026
Merged

lemon07r merged 2 commits into
masterfrom
chore/chrono-advisory

Conversation

@lemon07r

@lemon07r lemon07r commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Unblocks three CI issues encountered on master:

  1. RUSTSEC-2026-0543 (chrono unmaintained): replace chrono in eval/ with time (0.3.55, already in Cargo.lock via tantivy) and drop chrono plus unused transitive edges from Cargo.lock.
  2. Rust 1.100.0 clippy::needless_bool: simplify the trailing if ... { return false; } true in crates/vera-core/src/types.rs.
  3. Windows sccache command-line limit (os error 206): run windows-probe with direct rustc (which uses Cargo @response_file natively) instead of wrapping through sccache.

Local Verification

  • cargo fmt --all -- --check
  • cargo clippy --locked --workspace --all-targets -- -D warnings
  • cargo test --locked -p vera-eval (82 passed) and cargo test --locked -p vera-core types:: (100 passed)
  • cargo deny --locked check, cargo machete, cargo audit

Summary by CodeRabbit

  • Improvements
    • Benchmark reports continue to include current UTC timestamps in RFC 3339 format.
    • Search filtering continues to exclude generated content when that option is disabled, while honoring other active filters.
  • Maintenance
    • Updated the timestamp-handling and build configuration. These changes do not alter the app’s visible behavior.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 09:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The evaluator replaces chrono with time for benchmark report timestamps. Both benchmark paths use a shared RFC 3339 UTC timestamp helper. The Windows probe job removes sccache setup, and SearchFilters::matches simplifies its generated-content check.

Changes: Benchmark Timestamps

Layer / File(s) Summary
Generate and use UTC report timestamps
eval/Cargo.toml, eval/src/runner.rs
The evaluator replaces chrono with time and adds a helper that formats the current UTC time as RFC 3339. Both benchmark report paths use the helper. A test checks that the timestamp contains T and ends with Z.

Windows Probe Workflow

Layer / File(s) Summary
Update Windows probe configuration
.github/workflows/ci.yml
The Windows probe job removes sccache setup and environment configuration. Comments describe the wrapper's response-file command-line limit and resulting error.

Generated-Content Filter

Layer / File(s) Summary
Simplify generated-content check
crates/vera-core/src/types.rs
SearchFilters::matches replaces the explicit generated-content rejection branch and trailing true return with a negated condition. It still rejects generated content only when include_generated is Some(false), after the preceding checks pass.

Estimated code review effort: 3 (Moderate) | ~18 minutes

Change: Other

Suggested reviewers: citron07r

Merge Risk: Minimal · up to 1dc67

This PR swaps the evaluator's timestamp dependency, simplifies a boolean check, and drops sccache from the Windows probe CI job. No concrete defects were identified, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names three changes: unblocking Rust 1.100 clippy, the Windows sccache command-line limit, and RUSTSEC-2026-0543. The changeset covers all three: the chrono-to-time swap in eval/ with the ad…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names three changes: unblocking Rust 1.100 clippy, the Windows sccache command-line limit, and RUSTSEC-2026-0543. The changeset covers all three: the chrono-to-time swap in eval/ with the advisory-driven dependency cleanup, the needless_bool simplification in types.rs, and removal of sccache from the windows-probe job. The title is specific and accurate, though long at 82 characters and somewhat list-like.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 44c10ce and 1dc67ae.

Files selected for processing: 2

  • .github/workflows/ci.yml
  • crates/vera-core/src/types.rs

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@revera-lr7

revera-lr7 Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Revera review

Status: partial — no accepted findings, 1 unconfirmed

Review incomplete: one or more validations were inconclusive. Absence of findings is not evidence the change is clean; rerun or inspect the parts listed as not checked.

Checked: Reviewed all five changed files, lockfile dependency removals, Windows job configuration, filter callers/tests, and benchmark timestamp generation and consumers.

Timing: total 126s · index 77s · lanes 48s · validation 1.4s (p50 1.4s, p95 1.4s, first candidate at 125s) · 1 phase(s) incomplete · 1 phase(s) skipped

revera · strategy baseline · models: investigator=factory/gpt-6.1-sol@high

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Turn on auto-fix | Re-trigger cubic

@lemon07r lemon07r changed the title chore(deps): replace chrono with time in vera-eval for RUSTSEC-2026-0543 chore(ci): unblock Rust 1.100 clippy, Windows sccache limit, and RUSTSEC-2026-0543 Nov 18, 2026
@lemon07r
lemon07r merged commit 994d274 into master Nov 18, 2026
16 checks passed
@lemon07r
lemon07r deleted the chore/chrono-advisory branch November 18, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants