Repository navigation
feat(typing): Improve type hints for varwrap - #1114
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F4nx8G2TSRtJQCxJmv4AkW
# Conflicts: # doc/release_notes.rst
Merging this PR will not alter performance1 note
Comparing Footnotes
|
# Conflicts: # doc/release_notes.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes and closes #1029 by @RobbieKiwi, whose commits are kept unchanged on this branch. The original PR's fork branch could not be updated from here.
Note
The following content was generated by AI.
Changes proposed in this Pull Request
Same code change as #1029:
varwrapis typed with aParamSpec, so theVariablemethods that wrap anxarray.Datasetmethod (sel,isel,shift,rename,stack, ...) carry the wrapped method's parameters and returnVariablefor type checkers and IDEs, instead of an untypedCallable. See #1029 for the before/after screenshots and the notes on Pylance and ty.On top of #1029:
master.Closes #1029
Checklist
doc/release_notes.rstof the upcoming release is included.Generated by Claude Code