Skip to content

Escape comparison delimiters in generated JavaDoc - #984

Open
abhinavs1920 wants to merge 11 commits into
Netflix:masterfrom
abhinavs1920:fix-javadoc-comparisons-772
Open

abhinavs1920 wants to merge 11 commits into
Netflix:masterfrom
abhinavs1920:fix-javadoc-comparisons-772

Conversation

@abhinavs1920

Copy link
Copy Markdown

Fixes #772.

Escape stray < characters in Java schema descriptions, such as created_at:<now and <=2024, while retaining complete HTML tags and Javadoc code/literal blocks. Applied across data types, interfaces, enums and client descriptions. This is not a general HTML sanitizer.

Added a regression that runs JDK 17 Javadoc on the generated sources, plus a markup-preservation check. The generated-source regression fails on master with malformed-HTML errors and passes with this change.

Validation on Linux/JDK 17: 7 focused Javadoc tests passed; Kotlin main/test lint and git diff --check passed. Full core/integration and broader client test runs did not finish within the local execution window, so I cannot claim those passed. Other operating systems were not tested.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments in generated java objects may not be javadoc compliant

1 participant