Repository navigation
refactor(cli): use Rust SDK transport - #4817
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Label |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. cli — No explicit risk acceptance found
Review details
Advisory review; publication gates are unchanged. |
|
Rust consumers should consume from the SDK not the CLI. |
Resolve conflicts from the Rust SDK transport refactor (NVIDIA#4817) and the server-macros crate removal (NVIDIA#4818): - grpc_client keeps the SDK's channel construction (TLS discovery, edge tunnel, insecure mode) and re-attaches the CLI's GatewayInterceptor composing auth headers with W3C trace-context forwarding, using the SDK's re-exported raw gRPC client. The CLI never wires an OIDC refresher, so composing the interceptor client-side loses nothing from OpenShellClient::connect. - Drop the stale tls_server_name helper and tests; upstream moved server-name normalization into the SDK transport. - Cargo.lock: remove the deleted openshell-server-macros entry and regenerate for consistency. Signed-off-by: Chris Moore <cmoore@redhat.com>
Summary
Route CLI gateway connections through
openshell-sdkso TLS, mTLS, OIDC headers, insecure TLS, and Cloudflare edge transport have one owner. Existing commands retain generated RPC coverage through the SDK's raw client while the CLI drops its duplicate transport implementation and direct transport dependencies.Related Issue
Closes #4816
Changes
openshell-sdk.tokio-rustls,tokio-tungstenite, andtowerdependencies.Release Notes
Testing
Commands run:
cargo fmt --all -- --checkcargo check -p openshell-sdk -p openshell-clicargo test -p openshell-sdkcargo test -p openshell-cli --lib tls::testscargo test -p openshell-cli --test provider_commands_integration provider_list_json_empty -- --exactcargo clippy -p openshell-sdk --all-targets -- -D warningscargo clippy -p openshell-cli --all-targets -- -D warningsgit diff --checkChecklist