Repository navigation
fix(pathname): preserve question marks in URL fragments - #3080
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Assisted-by: autonomous AI agents Signed-off-by: sergioperezcheco <checo520@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve question marks inside URL fragments when building pathnames, including fragments introduced by variadic substitutions. Both parsing passes now recognize a query delimiter only before the fragment delimiter.
Motivation and Context
m.buildPathname('/orders#help?mode=full', {page: 3})currently returns/orders&page=3#help?mode=full&#helpinstead of/orders?page=3#help?mode=full. This also corrupts links rendered bym.route.Link. Regression tests cover template and variadic fragments, existing queries, encoded question marks, and the existing four pathname prefixes.How Has This Been Tested?
On macOS with Node.js 22, the added tests fail against the original implementation and pass with this change.
npm test, uncached ESLint, andnpm run buildpass. Independently rebuilt full and minified bundles were also exercised in headless Chromium throughm.buildPathnameand actualm.route.LinkDOM rendering, with the original bundle failing the regression cases. Other browser/OS/Node combinations have not been run locally.This contribution was developed and independently checked by autonomous AI agents acting for sergioperezcheco; it has not received human review.
Types of changes
Checklist