Repository navigation
Refactor event handling and update dependencies to Matthiesen Core - #22
Merged
Merged
Conversation
… for player handling
…er for message retrieval and update dependencies in various listeners and commands
… refactor existing code to utilize new config structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the mod from depending on "Matthiesen Lib API" to the newer "Matthiesen Core" library. It updates all relevant code, configuration, and documentation to use the new core library and its APIs. Additionally, it removes obsolete event handler classes and simplifies event registration using the new platform events system. There are also minor cleanups and improvements to code structure and logging.
Dependency and API migration:
matthiesen_lib_apiwithmatthiesen_core, including commands, permissions, configuration, and utility classes throughout the codebase. (CobbledLevelControl.java,LevelControlCommand.java,CobbledLevelControlConfigManager.java,PermissionHelpers.java, etc.) [1] [2] [3] [4]README.md,.github/workflows/publish-release.yml) [1] [2] [3] [4] [5]Event handling refactor:
PlayerEventsandServerEvents, and replaced their functionality by subscribing directly toPlatformEventsinCobbledLevelControl.java. [1] [2] [3]Code cleanup and simplification:
Gsoninstances in config classes, and unnecessary logging/debug lines in event listeners. (DifficultyConfig.java,MainConfig.java,MessagesConfig.java,BattleStartEventsListener.java) [1] [2] [3] [4] [5] [6]Minor improvements:
These changes modernize the mod’s codebase, align it with the latest Matthiesen libraries, and simplify event and permission handling for easier maintenance and future development.