Repository navigation
[BF-7514]: Update dependencies to resolve CVE in shell-quote - #21
Merged
Merged
Conversation
GitHub Actions lts/* now resolves to Node 24, where jest-resolve fails under Yarn PnP because require.resolve.paths is unavailable in the ESM loader path.
ThomasTrepanier
marked this pull request as ready for review
June 25, 2026 13:48
ThomasTrepanier
enabled auto-merge (squash)
June 25, 2026 13:48
ThomasTrepanier
disabled auto-merge
June 25, 2026 19:05
Node 24.15+ broke require.resolve.paths on the require synthesized for CJS files loaded via the Yarn PnP zip loader, crashing jest-resolve at load time. Switching to nodeLinker: node-modules avoids the PnP loader entirely, so CI can stay on node-version: lts/*. Reverts the Node 22 pin.
ThomasTrepanier
enabled auto-merge (squash)
June 25, 2026 19:42
AdrienPoupa
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell-quotefrom 1.8.1 to 1.8.4 in the lockfile to address a critical command injection vulnerability (CVE-2026-9277 / GHSA-w7jw-789q-3m8p).nodeLinker: node-modulesso CI can stay onnode-version: lts/*(Node 24).Why
Shell-quote (Dependabot mhassan1#55): The vulnerable version is transitive via
@yarnpkg/builder→@yarnpkg/cli→ink→react-devtools-core. No upstream bump pulls in 1.8.4 reliably, so the lockfile was updated withyarn up -R shell-quote.Node linker: On Node 24.15+ (
lts/*in GitHub Actions),yarn testfails before any tests run.jest-resolvecallsrequire.resolve.paths('/')at module load time; under Yarn PnP, CJS dependencies are loaded through the zip loader and Node no longer exposesrequire.resolve.pathson that synthesizedrequire(Node 24.15+ / PnP regression). Pinning CI to Node 22 avoided the crash but is not desirable long term. Bumping jest does not fix it (the same call exists in currentjest-resolve). UsingnodeLinker: node-modulesavoids the PnP loader so jest loads as normal CommonJS and works on Node 24 while keepinglts/*.How was it tested
yarn up -R shell-quoteupdated lockfile to 1.8.4yarn why shell-quoteconfirms resolved version is 1.8.4yarn test— 39/39 passed locally on Node 24.15testjob green onlts/*(Node 24)