Repository navigation
chg: [netapi] return a reputation object instead of text attributes - #1018
Merged
Merged
Conversation
Member
|
Great. Thanks for the quick fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1014: @adulau suggested there that the module should use MISP objects instead of attributes, so the NetAPI module now returns a
reputationobject instead of two text attributes. It is built the same way as in dbl_spamhaus and spamcop (explicit types, since pymisp does not bundle the template yet).classification:maliciouswhen the value is listed now,suspiciouswhen only its registered domain is,unknownwhen it was listed in the past only or never. Absence from the feed is no opinion, so nothing is reported as benign.sourceNetAPI,list-nameNetAPI compromised domains,first-seen/last-seenin UTC,linkto the NetAPI domain lookup of the listed entry.textkeeps the listing summary and the Top 1M rank, so nothing from the old output is lost.related-to). Its attributes keepdisable_correlationand noto_ids, as before.Tests are updated for the new shape (15 pass). I also ran it against the live API: a listed domain, a hostname matched through its registered domain, a past listing and a clean domain.