Skip to content

chg: [netapi] return a reputation object instead of text attributes - #1018

Merged
adulau merged 1 commit into
MISP:mainfrom
slavaolesik:netapi-reputation-object
Oct 27, 2026
Merged

adulau merged 1 commit into
MISP:mainfrom
slavaolesik:netapi-reputation-object

Conversation

@slavaolesik

Copy link
Copy Markdown
Contributor

Follow-up to #1014: @adulau suggested there that the module should use MISP objects instead of attributes, so the NetAPI module now returns a reputation object instead of two text attributes. It is built the same way as in dbl_spamhaus and spamcop (explicit types, since pymisp does not bundle the template yet).

  • classification: malicious when the value is listed now, suspicious when only its registered domain is, unknown when it was listed in the past only or never. Absence from the feed is no opinion, so nothing is reported as benign.
  • source NetAPI, list-name NetAPI compromised domains, first-seen / last-seen in UTC, link to the NetAPI domain lookup of the listed entry.
  • text keeps the listing summary and the Top 1M rank, so nothing from the old output is lost.
  • The object references the queried attribute (related-to). Its attributes keep disable_correlation and no to_ids, as before.
  • A date in a form the module does not expect is left out of the date fields instead of failing the lookup.

Tests are updated for the new shape (15 pass). I also ran it against the live API: a listed domain, a hostname matched through its registered domain, a past listing and a clean domain.

@adulau
adulau merged commit 1de67c0 into MISP:main Oct 27, 2026
7 checks passed
@adulau

adulau commented Oct 27, 2026

Copy link
Copy Markdown
Member

Great. Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants