Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #796.
The module currently calls
/v1/iocs, which misses matches in other Intel 471 datasets. Switch to/v1/search?text=<attribute value>using the existing PyIntel471 client. A match in indicators, reports, posts or news now produces freetext even wheniocTotalCountis zero.uidfields recursively across all returned collections, preserving real hash fields.The endpoint and
textparameter follow Intel 471's Global Search documentation; collection handling follows its SearchSchema.Validation: 42 regression tests pass on Python 3.12 with PyIntel471 0.1.1, exercising the real client's prepared HTTP requests with the transport mocked. Coverage includes every supported input type, URL/email encoding, non-IOC results, nested UID cleanup, empty results and API failures. isort, flake8, Black formatting through its Python API, and
git diff --checkpass.No live Intel 471 credentials were available. Before merging, validate an IOC known to exist in malware intelligence or news but absent from the IOC collection. Global search remains limited to the account's entitlements and the API's default first page; this change does not add pagination.