Repository navigation
Sample Naming - #8643
Open
FrisbyNinja wants to merge 14 commits into
Open
Sample Naming#8643FrisbyNinja wants to merge 14 commits into
FrisbyNinja wants to merge 14 commits into
Conversation
added 4 commits
November 12, 2026 19:20
…nto sample-naming Merged to allow initial commit
yohannd1
suggested changes
Nov 12, 2026
yohannd1
left a comment
yohannd1
left a comment
Contributor
There was a problem hiding this comment.
Mostly a style review. Haven't properly analyzed it yet.
yohannd1
reviewed
Nov 12, 2026
Start style edit (suggested by @yohannd1) Co-authored-by: Yohanan <23298480+yohannd1@users.noreply.github.com>
Continue style edit Co-authored-by: Yohanan <23298480+yohannd1@users.noreply.github.com>
Continue style edit Co-authored-by: Yohanan <23298480+yohannd1@users.noreply.github.com>
Continue style edit Co-authored-by: Yohanan <23298480+yohannd1@users.noreply.github.com>
Continue style edit Co-authored-by: Yohanan <23298480+yohannd1@users.noreply.github.com>
Continue style edit Co-authored-by: Yohanan <23298480+yohannd1@users.noreply.github.com>
Continue style edit Co-authored-by: Yohanan <23298480+yohannd1@users.noreply.github.com>
Continue style edit Co-authored-by: Yohanan <23298480+yohannd1@users.noreply.github.com>
Author
|
Fixed style issues : Thanks for catching those ! |
Author
|
Having read back through the style guidelines, I think it appropriate to change the comments explaining m_name and m_name_set in SampleClip.h to Doxygen ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit attempts to solve one aspect of #1471 : "Sample distinction via naming".
The way this is achieved here is through a new option on the sample clip context menu ("Rename clip") :
Mirroring the mixer's renaming system, a text box appears, allowing a new name to be typed.
The name does not overwrite any previous important naming/functionality : It is essentially a display name.
Copying the clip retains the name, as does saving the project.