Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task local storage key
(INLINE_LINSOLVE_CACHE, typeof(A), size(A))got boxed on every lookup, one 48 B allocation per inline linear SCC solve. The caches now sit in one typedDictunder theSymbolkey, so the lookup doesn't allocate. Building a missing cache is moved out of line, since inlined it costs every solve ~25 ns on Julia 1.13 and eats the gain.One allocation less per solve, also under ForwardDiff: the allocation test's RHS call goes from 128 to 80 B (112 to 64 B on 1.10). The lookup takes 19 ns instead of 39, and a model with three blocks 310 ns instead of 380. The test bound is now 256, which leaves room for #168's result array, and the lookup itself is checked to allocate nothing.