Skip to content

Replace _counttuple with fieldcount - #151

Merged
fredrikekre merged 3 commits into
JuliaCollections:masterfrom
KristofferC:fix-julia-1.14-counttuple
Oct 29, 2026
Merged

fredrikekre merged 3 commits into
JuliaCollections:masterfrom
KristofferC:fix-julia-1.14-counttuple

Conversation

@KristofferC

Copy link
Copy Markdown
Contributor

Replace the removed private _counttuple helper with fieldcount.

Add iterator trait regression tests for zip_longest.

@codecov

codecov Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.41%. Comparing base (7ac0198) to head (8ca671a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   91.25%   92.41%   +1.15%     
==========================================
  Files           1        1              
  Lines         389      369      -20     
==========================================
- Hits          355      341      -14     
+ Misses         34       28       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KristofferC

Copy link
Copy Markdown
Contributor Author

cc @nsajko (would be good with a new release with this fix)

oxinabox
oxinabox previously approved these changes Sep 1, 2026
@KristofferC

Copy link
Copy Markdown
Contributor Author

(I can't merge)

Comment thread test/runtests.jl Resolved
@oxinabox
oxinabox dismissed their stale review September 1, 2026 09:10

didn't look close enough

Co-authored-by: Frames White <oxinabox@ucc.asn.au>
@IanButterworth

Copy link
Copy Markdown

Claude:

IterTools has failed PkgEval on Julia nightly (1.15-DEV) since July 2026, because it uses the removed internal Base.Iterators._counttuple. This PR fixes it. The current CI failure comes from the applied review suggestion: @test IteratorEltype(typeof(it))) == Base.HasEltype() has an extra ). With that removed, could this be merged and released?

Written with Claude Code (Opus 5.5).

Comment thread test/runtests.jl Resolved
@fredrikekre
fredrikekre merged commit 4e7c0ea into JuliaCollections:master Oct 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants