Repository navigation
Conversation
+ use System.Version instead of numerical types + add version converter for json
+ make script template use new StoryboardApiVersion versioning
…lly doing it again in lua to avoid stability issues
+ change version to use ints instead of system.version
+ add explicit conversion for lua hitobjects
+ make it use resource locations
latest members get priority over older members with the same name + remove event types enum since we now rely on resource locations
since lua versions now use ints instead of `System.Version`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
StoryboardApiVersionwhich validates and holds latest version as well as being a changelogScriptRunner.Initializemethod for script runnersScriptRunner.Runso we have minimumVersionedLua.Resolvecalls. a general resolve after initializing (always version 1) and one afterSetVersion(the selected version)VersionedLuafor registering members based onLuaVersionAttributeLuaVersionResolverjust selects a version from candidatesToLuaTableNotesInRange,EventsInRange, etc. functions have been replaced byObjectsInRangeusing resource locationsNotesInRangenow uses resource locations[Obsolete]attributes which would add@deprecatedI might've forgotten the rest...
To be precise it prioritizes the most latest version, only matters for conflicting member names.