Skip to content

Correct why release.yml avoids YAML anchors - #3136

Merged
Eliah Kagan (EliahKagan) merged 1 commit into
GitoxideLabs:mainfrom
EliahKagan:claude/explain-yaml-anchor-avoidance
Oct 29, 2026
Merged

Eliah Kagan (EliahKagan) merged 1 commit into
GitoxideLabs:mainfrom
EliahKagan:claude/explain-yaml-anchor-avoidance

Conversation

@EliahKagan

@EliahKagan EliahKagan commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

We have outdated information in release.yml about why we're not using YAML anchors for an array whose contents we don't want to get out of sync. I think we should continue not using them at this time, but the reason is that Zizmor only partially supports them, not that GitHub Actions doesn't (since GHA does support them since some time ago).


Written by Claude (Claude Code, Claude Opus 5.5) on Eliah Kagan's behalf, besides the parenthesized note:

The features matrix in release.yml is written out twice, in build-release and build-macos-universal2-release. Sharing it with a YAML anchor would keep the two copies from drifting apart, but the comment about this said GitHub Actions doesn't support anchors, which is no longer true. What still stands in the way is zizmor: its anchor support is beta, and it logs a warning on any input that contains an anchor. This keeps the repetition and corrects the comment to give that reason, linking to zizmor's documentation.

This came up while revisiting an old fork-internal PR, EliahKagan#162 (note: which was fork-internal because I was also using it to test some Copilot problems -Eliah), which tried to correct the same comment but said zizmor doesn't support anchors at all.

🤖 Generated with Claude Code

The comment saying the `features` array is repeated because GitHub
Actions doesn't support YAML anchors is out of date. GitHub Actions
supports them:
https://docs.github.com/en/actions/reference/workflows-and-actions/reusing-workflow-configurations#yaml-anchors-and-aliases

The reason to keep avoiding them is `zizmor`. It has handled inputs
with anchors since 1.16.0, but its documentation still describes that
support as beta:
https://docs.zizmor.sh/usage/#yaml-anchors

It also logs a warning, pointing to that page, whenever any input
contains an anchor. And it reports findings in aliased content at the
anchor, once per alias, rather than where each alias is used.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@EliahKagan
Eliah Kagan (EliahKagan) marked this pull request as ready for review October 29, 2026 18:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T18:26:29.430937Z e90b919 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@EliahKagan EliahKagan left a comment •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait on the Codex review just in case it spots problems with the new comment wording, even though it looks good to me (and to Claude), then I'll enable auto-merge.

Update: As expected, it passed the quick Codex review as well.

@EliahKagan
Eliah Kagan (EliahKagan) merged commit 86a848e into GitoxideLabs:main Oct 29, 2026
33 checks passed
@EliahKagan
Eliah Kagan (EliahKagan) deleted the claude/explain-yaml-anchor-avoidance branch October 29, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant