Repository navigation
add availability recording for traffic contracts and virtual keys - #313
Open
noahpodgurski wants to merge 3 commits into
Open
noahpodgurski wants to merge 3 commits into
noahpodgurski wants to merge 3 commits into
Conversation
subpath
reviewed
Nov 6, 2026
| "Traffic contract enforcement failed for " | ||
| f"service_type={service_type}: {exc}" | ||
| ) | ||
| if env.TRAFFIC_CONTRACT_FAIL_OPEN_ON_REDIS_ERROR: |
Collaborator
There was a problem hiding this comment.
suggestion:
I think we need to wrap Redis calls into SLOs too 🙏
We could record it as a failure before raising (with a new TRAFFIC_CONTRACT_UNAVAILABLE reason mapped to FAILURE), and maybe assert it in the 503 test?
just a suggestion from the top of my head, not sure how relevant it is
record_availability(
authorized_request, AvailabilityReason.TRAFFIC_CONTRACT_UNAVAILABLE
)
raise HTTPException(
status_code=503,
detail={"error": "Traffic contract enforcement unavailable."},
) from exc
Member
Author
There was a problem hiding this comment.
Great idea, thanks 🙏
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new