Skip to content

Refactor block material - #2997

Open
TomyLobo wants to merge 2 commits into
masterfrom
refactor-block-material
Open

TomyLobo wants to merge 2 commits into
masterfrom
refactor-block-material

Conversation

@TomyLobo

@TomyLobo TomyLobo commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator
  • Add BlockState.getMaterial()
  • Add ShapeType parameter to BlockMaterial.isFullCube

@TomyLobo
TomyLobo requested a review from a team as a code owner August 2, 2026 12:53
@TomyLobo
TomyLobo changed the base branch from version/7.3.x to master August 2, 2026 13:00
Comment thread verification/src/changes/accepted-core-public-api-changes.json Outdated
@me4502

me4502 commented Aug 4, 2026

Copy link
Copy Markdown
Member

Also alongside octy's review, this currently does not compile, if you'd be able to please fix that too

@TomyLobo
TomyLobo force-pushed the refactor-block-material branch 5 times, most recently from c8b8ac1 to 1b9e3b1 Compare August 18, 2026 23:55
@TomyLobo
TomyLobo enabled auto-merge August 23, 2026 10:51
@TomyLobo
TomyLobo force-pushed the refactor-block-material branch from 1b9e3b1 to 3321cc3 Compare September 28, 2026 23:08
@TomyLobo
TomyLobo force-pushed the refactor-block-material branch 2 times, most recently from c27d861 to 55415c2 Compare October 27, 2026 03:40
@me4502
me4502 requested a review from octylFractal October 29, 2026 08:17
@TomyLobo
TomyLobo added this pull request to the merge queue Oct 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 29, 2026
@me4502

me4502 commented Oct 30, 2026

Copy link
Copy Markdown
Member

This appears to have hit merge conflicts with the verification files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants