Repository navigation
fix: restore hmr client port on Vite 8.1+ - #637
Merged
Merged
Conversation
Vite's hmr compatibility getter owns clientPort even when it is unset. Check the value instead so inline server config does not suppress the default websocket port. Closes #636.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue #636
Description 📖
This pull request restores HMR on Vite 8.1+ when
vite devpasses an inlineserverconfiguration.Closes #636.
Background 📜
Vite 8.1 exposes the deprecated
server.hmrtransport options through compatibility getters. The wrapper ownsclientPorteven when no value was configured.An inline
server: {}causes Vite to install that wrapper before the plugin'sconfighook runs. The property-ownership check then treats the unset port as a user override, so the browser tries to connect to the Rails port instead of the Vite port.The existing tests called the configuration loader directly, bypassing Vite's config merge.
The Fix 🔨
Using the configured values to distinguish an unset port from an explicit override. Explicit ports, including
0, remain untouched, as do disabled HMR and WebSocket transports.