Skip to content

docs(installer): record that only privileged accounts read the data folder - #2196

Open
Benoît Cortier (CBenoit) wants to merge 1 commit into
masterfrom
claude/quirky-faraday-dq6wwx
Open

Benoît Cortier (CBenoit) wants to merge 1 commit into
masterfrom
claude/quirky-faraday-dq6wwx

Conversation

@CBenoit

Copy link
Copy Markdown
Member

The Gateway installer no longer gives BUILTIN\Users read access to %ProgramData%\Devolutions\Gateway (#2190), but package/WindowsManaged/INTENT.md only restricted who can change what the Gateway stores there.
Reading was not covered by any statement, so nothing in the intent would stop a later change from granting read access back.

This proposes wording the first Data folder statement as "read or change" and states why: the folder holds session recordings, private keys and the configuration.
The code already matches (PROGRAM_DATA_SDDL_TEMPLATE in package/WindowsManaged/Resources/Includes.cs, checked by DataFolderTests.OnlySystemAdministratorsAndTheServiceAccountCanReadTheData).

This is an intent-file change, so a human owner needs to accept the wording.
The Agent installer still grants Users read access to %ProgramData%\Devolutions\Agent, which matches its own intent; this PR leaves it alone.

Issue: DGW-504


Generated by Claude Code

…older

The Gateway installer no longer gives Users read access to its data
folder, but the intent only restricted who can change what the Gateway
stores there. Stating the read restriction and its reason keeps a later
change from granting read access back to other accounts.

Issue: DGW-504

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MzSAeJjLLvVt2z6YytpRv9
Copilot AI balanced review requested due to automatic review settings November 16, 2026 01:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The expanded installer read-access restriction requires explicit human-owner acceptance because code and existing tests cannot establish that security commitment on the owner’s behalf.

No open issues 🎉

What changed in this PR

This documentation-only PR records the Gateway data-folder read restrictions introduced in #2190, aligning installer intent with existing permissions.

Changes:

  • Limits read access, as well as modification, to SYSTEM, administrators and the service account.
  • Explains that the restriction protects session recordings, private keys and configuration.
  • Leaves installer behavior and Agent permissions unchanged; the proposed intent wording requires human-owner acceptance.
File Description
package/​WindowsManaged/​INTENT.md Explicitly restricts data-folder read access and explains why.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants