Repository navigation
docs(installer): record that only privileged accounts read the data folder - #2196
Open
Benoît Cortier (CBenoit) wants to merge 1 commit into
Open
Benoît Cortier (CBenoit) wants to merge 1 commit into
Benoît Cortier (CBenoit) wants to merge 1 commit into
Conversation
…older The Gateway installer no longer gives Users read access to its data folder, but the intent only restricted who can change what the Gateway stores there. Stating the read restriction and its reason keeps a later change from granting read access back to other accounts. Issue: DGW-504 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MzSAeJjLLvVt2z6YytpRv9
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The expanded installer read-access restriction requires explicit human-owner acceptance because code and existing tests cannot establish that security commitment on the owner’s behalf.
No open issues 🎉
What changed in this PR
This documentation-only PR records the Gateway data-folder read restrictions introduced in #2190, aligning installer intent with existing permissions.
Changes:
- Limits read access, as well as modification, to SYSTEM, administrators and the service account.
- Explains that the restriction protects session recordings, private keys and configuration.
- Leaves installer behavior and Agent permissions unchanged; the proposed intent wording requires human-owner acceptance.
| File | Description |
|---|---|
package/WindowsManaged/INTENT.md |
Explicitly restricts data-folder read access and explains why. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gateway installer no longer gives
BUILTIN\Usersread access to%ProgramData%\Devolutions\Gateway(#2190), butpackage/WindowsManaged/INTENT.mdonly restricted who can change what the Gateway stores there.Reading was not covered by any statement, so nothing in the intent would stop a later change from granting read access back.
This proposes wording the first Data folder statement as "read or change" and states why: the folder holds session recordings, private keys and the configuration.
The code already matches (
PROGRAM_DATA_SDDL_TEMPLATEinpackage/WindowsManaged/Resources/Includes.cs, checked byDataFolderTests.OnlySystemAdministratorsAndTheServiceAccountCanReadTheData).This is an intent-file change, so a human owner needs to accept the wording.
The Agent installer still grants Users read access to
%ProgramData%\Devolutions\Agent, which matches its own intent; this PR leaves it alone.Issue: DGW-504
Generated by Claude Code