Repository navigation
Newsletter preview: wrap long lines on all tabs; shareable preview shows only the issue - #443
Merged
alexeygrigorev merged 2 commits intoNov 13, 2026
Conversation
…ows only the issue Long URLs and inline code no longer stretch the preview card past the viewport: grid tracks are pinned to minmax(0,1fr), prose/code/links use overflow-wrap:anywhere, and pre blocks scroll inside the card. The code-gated shareable preview is reader-facing only: the tab bar is staff-only and the external API payload no longer carries brief.md or sources.md (markdown or rendered HTML). Adds a Playwright regression (long URL + long inline code) asserting no horizontal overflow on each staff tab and on the shareable preview at 1280 and 390 widths. Intake 646dfb96 (t2320u).
…iew shows only the issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intake 646dfb96 (t2320u).
minmax(0,1fr)withmin-width:0. Prose, links and inline code useoverflow-wrap:anywhere, andpreblocks scroll horizontally inside the card.brief/sources(both markdown and rendered HTML). Brief, Sources and Raw stay on the authenticated page.backend/e2e/newsletter-preview-overflow.spec.jsuses a long URL and long inline code and asserts no horizontal page or card overflow on every staff tab and on the shareable link at 1280 and 390 widths. It also checks that the shareable view has no tabs and no sources text. On the old code it fails (page scrollWidth 1857 > 1280).Only layout and tab visibility change here. No issue or sources content is edited.