Repository navigation
Fix podcast cover layout regression (gap, clipped pill, missing date/logo) - #442
Merged
alexeygrigorev merged 1 commit intoNov 13, 2026
Conversation
…ks.Club logo Root cause: the deployed bundle's podcast-1 templates pinned the title at a fixed top and the portrait at a fixed y (square: top 1050), so short titles left a huge void and the portrait + name pill sat at the bottom edge; no date/time or logo fields existed. Compared against the original Figma-derived kit (dataops-knowledge banner-generator): centered title directly above a large portrait, pill inside canvas. Adds eventDate/eventTime/eventWhen fields from the Card, a flow-layout template generator, a bundle build script, bundle key bump, docs and a Chromium geometry regression spec for square and landscape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes intake b0213fc8 (Madhu square 2000x2000 podcast cover).
Root cause: deployed bundle
e8f5c854…one-speaker podcast templates used absolute positions (title top 360, portrait top 1050 square); short titles left a huge gap, portrait+pill sat against the bottom edge, and the template had no date/time or DataTalks.Club logo fields. Known-good reference: original Figma-derived kit in dataops-knowledgebanner-generator/templates/podcast-1-speaker-luma/youtube-podcast(title directly above large portrait, pill inside canvas).Fix: flow-layout templates (
podcastLayout.ts),eventDate/eventTime/eventWhenfrom Card eventTime/anchorDate, new bundle09191882…(uploaded, content-addressed) incl. logo asset, bundle key parameter bumped.Tests:
backend/e2e/banner-podcast-layout.spec.ts(square+landscape x short/normal/long titles: bboxes inside canvas, logo/date present, gap bound), plus unit test for schedule fields.Not touching Luma. Existing non-podcast-1 templates unchanged.