Repository navigation
Allow anonymous reads of hosted public images through the portal auth gate - #441
Merged
Merged
Conversation
…th gate Prod returned 401 for GET /api/public-images/:id because the portal's browser-auth gate (only active when Cognito is configured) did not allowlist it, so sponsors opening a brief by access code saw the uploaded image fail to load. Add it next to the sponsor-doc allowlist and cover it in the portal-mode suite. Intake 4955a821 (AC5 live check).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live AC5 check for intake 4955a821 found prod returning 401 for
GET /api/public-images/:id(the shared hosting from #439). The portal browser-auth gate inbackend/src/docs/portal.tsruns only when Cognito is configured, so local/e2e runs passed, but on prod a sponsor/guest opening a brief by access code got the upload stored and then a broken image.isAnonymousPublicImageRequest(GET only) in the portal gate next to the sponsor-doc allowlist. POST/DELETE stay signed-in only.docs-portal.test.ts): anonymous GET returns the bytes, anonymous POST/DELETE stay 401. Fails without the fix, passes with it.Also unblocks intake c342af2b (sponsor graphics), which reuses this hosting.