Repository navigation
Templates: keep list in place, Steps heading, browser icon, per-step bindings - #411
Merged
Merged
Conversation
…'s own process doc and template bindings - restore the list scroll after the rebuilt list is attached (a detached element ignored scrollTop, so selecting a card jumped the list to the top) - rename the heading to Steps - show a browser icon beside browser-required step names instead of 'Browser required' text, keeping the due offset on the right - clicking a Steps row opens that step's instructions and settings in place, with links to exactly its instruction_doc_id (process doc, or template for template.* docs) and step anchor Intake cdb7e0b4 (t1998u, t1999u, t2000u, t2003u, t2004u)
The Templates surface imports src/surfaces/tasks/template-steps.js, but the file was never declared in backend/src/docs/frontend-assets.json, so verify-frontend-artifact failed the build with 'frontend import is missing from asset manifest'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intake cdb7e0b4-b52f-440f-84c1-4de6b1b9319f (t1998u, t1999u, t2000u, t2003u, t2004u; t2002u linked-event reading superseded and not implemented).
scrollTop, so the saved offset never applied. Now it is restored once the list is attached.What a new card runs→Steps.aria-labelBrowser required) beside the step name. The due offset stays on the right, and theBrowser requiredtext is gone.instructionDocId(process doc, plus theinstruction_step_idanchor;template.*docs are listed as the step's Template) and itsinstructionsUrl. Nothing comes from the template-wide docs list. No template or event data is changed.Tests:
node --test frontend/test/templates-surface-steps.test.mjs(bindings, heading, icon placement, due-date preservation, row detail links, scroll restore).