Repository navigation
Fix deferred disposition target-period CLI flag - #320
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dataops reconcile disposition ... --target-period YYYY-MMlost the target month because the flag parser producestargetPeriodwhile the handler readtarget-period. Deferred dispositions therefore failed the API's later-month validation even with a valid flag. Read the canonical parsed property and migrate the direct handler fixture.A synthetic integration test launches the actual CLI binary against a loopback HTTP mock. It verifies both spaced and equals forms send the exact target month, digest, and version; missing target month still receives the API400 rejection, and missing required evidence fails before HTTP.
Validation: all30 targeted CLI cases pass, including a red-before/green-after reproduction of the original400; JavaScript syntax and diff checks pass. CLI-only change; no financial data operations.