Repository navigation
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 7.35% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 68 functions across 12 files. (11 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Issue #1437requires optionalon_ready_codeafter the first scene load and one frame, orwait_untilvaluesscene_loadedandfirst_frame. The PR adds these options to `manage_editor(action="pla…Out of Scope Changes check The changes remain within issue #1437. The Unity service, Python REST and CLI paths, status polling, tests, and generated documentation support Play Mode startup waiting or one-time startup code. No u…Title check The title clearly and concisely describes the primary feature: waiting for Play Mode startup and running code once when ready. Description check The description follows the repository template and provides the feature summary, change details, compatibility information, testing results, documentation updates, related issue, and additional notes…
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 7.35% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 68 functions across 12 files. (11 skipped: 11 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
haranishi
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Entering Play Mode alone does not confirm that initialization is complete. A normal domain reload resets static variables set beforehand, and the next operation proceeds before the scene's
Startfinishes.Adds startup waiting and post-startup code execution to
manage_editor(action="play")so that the next operation can proceed after initialization is complete.Type of Change
Changes Made
wait_until="scene_loaded"|"first_frame",on_ready_code, andwait_timeout. Post-startup code runs once afterStartand 1 frame complete, and its result is returned indata.on_ready_result.execute_codefor compiler and safety checks.get_play_mode_startupand the CLI'seditor play-statusallow status checks after a timeout or a lost response. Existing calls without startup options retain their previous behavior.Compatibility / Package Source
betaas a localfile:package.142ea0af4890337f0ff6658df61db23982313717.tools/check-unity-versions.sh. The specified 4 versions were not installed, so all 4 checks were skipped.Testing/Screenshots/Recordings
Startand LateUpdate → the code ran 1 time, and still only 1 time when the same ID was resent, and cancellation when Play Mode stopped.--check, checked that both skill copies matched, conducted an independent review, and checked the information in the public diff and PR description.Documentation Updates
tools/UPDATE_DOCS_PROMPT.mdRelated Issues
Fixes #1437
Additional Notes
scene_loadeddoes not guarantee thatStarthas completed. Usefirst_frameoron_ready_codewhen initialization must be complete.The default wait is 30 seconds, with a range of 1–300 seconds. A timeout does not stop Play Mode. Pending code is canceled on timeout, but code that has already started executing may complete.
After a lost response, check the returned job ID on the same Unity instance. Results are retained for the latest 16 jobs within the same Editor session.
Fork CI verification
Checked the GitHub Actions results for the same commit
3eaa4b23fed490a159d67e5bc564b59636cc344f. The Python tests succeeded, as did the harness tests that run without Unity.C# compilation also succeeded with Unity 6000.0.75f1. Runtime and Editor were compiled for each of the Windows, macOS, and Linux configurations.
The docs build succeeded. The generated-docs drift check also succeeded.
The E2E tests and the Unity Editor tests that require a license were skipped.
The upstream GitHub Actions are waiting for a maintainer to approve the run for the current commit. The CI successes above are results from runs on the fork that verified the same commit.
Summary by CodeRabbit