Repository navigation
Conversation
Co-authored-by: chris1111 <6248794+chris1111@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enhance GitHub Actions workflow with hardening improvements
Add hardened macOS build and alpha prerelease workflow
Oct 5, 2026
chris1111
marked this pull request as ready for review
October 5, 2026 02:43
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The SDK checkout location does not match the Xcode project's configured search paths, so the build cannot locate MacKernelSDK.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds a hardened GitHub Actions workflow to build, package, and publish alpha VoodooHDA releases.
Changes:
- Builds and packages the kernel extension on macOS.
- Publishes guarded prereleases from
main. - Pins actions and limits permissions, concurrency, and runtime.
| File | Description |
|---|---|
.github/workflows/main.yml |
Adds the build, artifact, and prerelease workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+47
to
+51
| xcodebuild -project tranc/VoodooHDA_BS.xcodeproj -target VoodooHDA \ | ||
| -configuration "$CONFIGURATION" -jobs 3 ARCHS=x86_64 \ | ||
| SYMROOT="$PWD/build/products" OBJROOT="$PWD/build/obj" \ | ||
| CODE_SIGNING_ALLOWED=NO GIT_COMMIT="_$(git rev-parse --short HEAD)" \ | ||
| build > logs/VoodooHDA.log 2>&1 || { tail -100 logs/VoodooHDA.log; exit 1; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
.github/workflows/main.yml, based on the version in #26 (not yet merged), with a hardening pass. The workflow builds VoodooHDA on macOS, packages the kext, and publishes an alpha prerelease frommain. Its structure and intent are unchanged.actions/checkout,actions/upload-artifactandactions/download-artifactare pinned to commit SHAs, each with a version comment: checkout v4.3.1, upload-artifact v4.6.2, download-artifact v4.3.0.MacKernelSDKpin is unchanged.buildhastimeout-minutes: 45andprereleasehastimeout-minutes: 15. Both values are estimates, so please adjust them to real build times.paths-ignorefor**.md,LICENSEand.github/ISSUE_TEMPLATE/**applies to bothpushandpull_request.pushis limited tobranches: [main].concurrencygroup cannot dedupe push and PR runs, because they use different refs (refs/heads/xandrefs/pull/N/merge). Limitingpushtomainis what prevents the duplicate runs.contents: read.contents: writeis set on theprereleasejob alone.git log -5tofetch-depth: 5, so the two are kept in sync.::error::if theawk-extractedCURRENT_PROJECT_VERSIONis empty. This prevents tags likev-alpha.v${version}-alpha.Review notes:
mainbranches without an open PR no longer build.