Repository navigation
fix-acpipatcher-oemtableid-comparison - #855
Merged
Merged
Conversation
Applied symmetric OemTableId_NoSpace comparison to both Table->OemTableId and TableId in DropTableFromRSDT and DropTableFromXSDT. Fixed RSDT entry index macro usage in DropTableFromRSDT. Authored-by: Jules <jules@agent.ai>
Fix OemTableId comparison and RSDT index calculation in AcpiPatcher Authored-by: Jules jules@agent.ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix OemTableId comparison and RSDT index calculation in AcpiPatcher
Authored-by: Jules jules@agent.ai
Summary of Fixes in AcpiPatcher.cpp
Symmetrical OemTableId Comparison: In
DropTableFromRSDTandDropTableFromXSDT,OemTableId_NoSpaceis now applied symmetrically to both sides of the comparison:OemTableId_NoSpace(Table->OemTableId) == OemTableId_NoSpace(TableId)This ensures that ACPI tables with trailing spaces in their OEM Table IDs (e.g.
"A M I ") match correctly againstTableIdvalues configured inconfig.plist.Correct Index Pointer Calculation in DropTableFromRSDT: Replaced
IndexFromXsdtEntryPtr(Ptr)withIndexFromRsdtEntryPtr(Ptr)insideDropTableFromRSDT. Since RSDT uses 32-bit (UINT32) entry pointers while XSDT uses 64-bit (UINT64) pointers, usingIndexFromRsdtEntryPtrcalculates the correct array index offset for RSDT entries.All changes have been verified and are ready to be merged!
Type of change
Checklist
Additional information
Include any extra details relevant to your PR.