Repository navigation
fix(dashboard): clarify log plugin filter scope - #10691
Merged
Soulter merged 1 commit intoOct 24, 2026
Merged
Conversation
The plugin filter on the Logs page only lists plugins found in the retained log cache, but its placeholder said "All plugins", which made users think installed plugins were missing. Rename the placeholder to "Plugins in current logs", add a hint that the list is not the installed-plugin list, update all locale bundles and the WebUI docs, and add a test documenting the option source. Fixes AstrBotDevs#10667
Soulter
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10667
The plugin dropdown in the Logs page filters only lists plugins that appear in the retained in-memory log cache. The cache is capped (1000 entries in the frontend, roughly 500 events from the server history), so installed plugins that have never emitted a log, plugins whose logs have been evicted, and plugins whose log records are not tagged with a plugin name never appear in the list. Because the placeholder said "All plugins", users interpreted this as an incomplete or failed plugin installation (issue #10667).
This change keeps the existing filter behavior and fixes the misleading wording: the dropdown now states that it lists plugins in the current logs, and a hint clarifies that the list is not the installed-plugin list.
Modifications / 改动点
dashboard/src/components/shared/ConsoleDisplayer.vue: change the plugin filter placeholder from "All plugins" to "Plugins in current logs" and add a persistent hint explaining that the options come from the current logs, not the installed plugin list.dashboard/src/i18n/locales/{zh-CN,en-US,ja-JP,ru-RU}/features/console.json: replacefilters.allPluginswithfilters.pluginsInLogsand addfilters.pluginsInLogsHint.dashboard/tests/consoleFilters.test.mjs: add a regression test asserting that plugin options are derived only from the retained log cache, so installed plugins known by display name alone do not create options while log-only plugins remain selectable.docs/zh/use/webui.mdanddocs/en/use/webui.md: document that the dropdown lists plugins appearing in the current logs rather than all installed plugins.This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Verification steps:
Test results:
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
📚 I checked the affected WebUI instructions and screenshots in
docs/zhanddocs/enagainst the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog./ 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新
docs/zh和docs/en的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Clarify the Logs plugin filter scope to prevent users from mistaking the retained log-based list for the installed-plugin list.
Bug Fixes:
Enhancements:
Documentation:
Tests: