Repository navigation
Jellyfin builds: compare on the catalog's web_version (#124) - #125
Merged
Merged
Conversation
Every build in the Jellyfin family declares version 0.1.0 in its config.xml, the wrapper's own. The TV reports 0.1.0, the catalog says 0.1.0, and TV-Store never offered an update. The catalog now gives the jellyfin-web version inside each build as web_version (Apps2Samsung#1117), and TV-Store uses it. - The variant carries web_version next to version; cards, the sheet, the install screens and the store in a browser show it instead of 0.1.0. - An install from TV-Store writes it down per package id, with the app and the file it belongs to (localStorage, a2s.tvstore.webversions). - state() and the pinned card compare the catalog's web_version with the one written down. Higher in the catalog is an update, and it joins Update all. - Nothing written down (installed from a phone or PC, or before this): the version reads as not known with the catalog's next to it, no update is offered and it stays out of Update all. The sheet and the On the TV panel say why, and that an install from here replaces a copy built on a PC. - The Jellyfin apps share one package id and one version, so the first in the catalog claimed the package whichever was installed. The app whose build was written down claims it now. - A record leaves with its package, so what comes back under that id from a phone or PC is not taken for the build TV-Store installed. A build without a web_version, and a catalog from before the field, compare as before. test/web-version.test.js runs the real page script in a vm with a stand-in for the DOM, the platform and the service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124.
Every build in the Jellyfin family declares version
0.1.0, so TV-Store never offered an update for one. The catalog now carries the jellyfin-web version of each build asweb_version(Apps2Samsung/Apps2Samsung#1117, already in the live snapshot), and TV-Store shows and compares that.What changes
web_versiongoes onto the variant next toversion. Anything that is not a plain version is ignored.a2s.tvstore.webversions): the app, the file and itsweb_version.state()and the pinned card compare the catalog'sweb_versionwith the one written down. Higher in the catalog is an update and joins Update all. Only the version counts, not the build date.web_versionwhere they showedv0.1.0.Two things beyond the five points
AprZAARz4rand all say0.1.0, so the first one in the catalog claimed the package whichever was installed. The app whose build was written down claims it now; without that, a legacy or AVPlay build installed from TV-Store would be compared as a build of "Jellyfin".Behaviour to know
web_version(the 10.8.z legacy builds have none) and a catalog from before the field compare as before.Jellyfin-mastersays13.0.0until 13 is released, so it shows no update until then.Tested
test/web-version.test.js(new) runs the realapp.jsin a vm with a stand-in for the DOM, the platform and the service: not installed, not known, update and Update all, same version, the claim, the record written at install and dropped with its package, a catalog without the field. It draws the On the TV page and the sheet and reads what they say. It fails on main.scripts/run-tests.sh: all tests pass.