Repository navigation
Conversation
garyo
approved these changes
Nov 16, 2026
garyo
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but all OpenFX commits need a DCO signoff in the commit message; Signed-off-by: Author Name <authoremail@example.com> or use -s when committing. Would you mind force-pushing with DCOs? Thanks!
gcc with -Wextra-semi warns about unnecessary semicolons. Signed-off-by: Nathan Weston <nweston@fastmail.com>
gcc with -Wcatch-value warns about "catching polymorphic type by value". Signed-off-by: Nathan Weston <nweston@fastmail.com>
nweston
force-pushed
the
fix/support-library-warnings
branch
from
November 16, 2026 18:05
7f4648c to
f151ef1
Compare
devernay
added a commit
to NatronGitHub/openfx
that referenced
this pull request
Nov 16, 2026
…er namespaces in ofxsHWNDInteract.cpp The Retimer fix (upstream AcademySoftwareFoundation#280) makes getFramesNeeded ask for the two frames around the source time integral(speed, 0, t), the frames the render fetches, instead of [t, t+1]: the test now expects that. ofxsHWNDInteract.cpp (fork-only, Windows) gets AcademySoftwareFoundation#291's namespace change too. Assisted-by: Claude Code/claude-opus-5-5
devernay
added a commit
to NatronGitHub/openfx
that referenced
this pull request
Nov 16, 2026
Port upstream fixes: Support warnings (AcademySoftwareFoundation#291), Support visibility (AcademySoftwareFoundation#278), Support and example plug-in fixes (AcademySoftwareFoundation#280, AcademySoftwareFoundation#281)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling the support library using gcc with all the warnings turned on generates some warnings. This PR fixes them.