Skip to content

Fix compiler warnings in the support library - #291

Open
nweston wants to merge 2 commits into
AcademySoftwareFoundation:mainfrom
nweston:fix/support-library-warnings
Open

nweston wants to merge 2 commits into
AcademySoftwareFoundation:mainfrom
nweston:fix/support-library-warnings

Conversation

@nweston

@nweston nweston commented Nov 16, 2026

Copy link
Copy Markdown

Compiling the support library using gcc with all the warnings turned on generates some warnings. This PR fixes them.

@garyo garyo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garyo garyo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but all OpenFX commits need a DCO signoff in the commit message; Signed-off-by: Author Name <authoremail@example.com> or use -s when committing. Would you mind force-pushing with DCOs? Thanks!

gcc with -Wextra-semi warns about unnecessary semicolons.

Signed-off-by: Nathan Weston <nweston@fastmail.com>
gcc with -Wcatch-value warns about "catching polymorphic type by
value".

Signed-off-by: Nathan Weston <nweston@fastmail.com>
@nweston
nweston force-pushed the fix/support-library-warnings branch from 7f4648c to f151ef1 Compare November 16, 2026 18:05
devernay added a commit to NatronGitHub/openfx that referenced this pull request Nov 16, 2026
…er namespaces in ofxsHWNDInteract.cpp

The Retimer fix (upstream AcademySoftwareFoundation#280) makes getFramesNeeded ask for the two frames around the source
time integral(speed, 0, t), the frames the render fetches, instead of [t, t+1]: the test now
expects that. ofxsHWNDInteract.cpp (fork-only, Windows) gets AcademySoftwareFoundation#291's namespace change too.

Assisted-by: Claude Code/claude-opus-5-5
devernay added a commit to NatronGitHub/openfx that referenced this pull request Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants