|
| 1 | +import { startTestServer, type TestServer } from "@internal/testcontainers/webapp"; |
| 2 | +import type { WorkerQueueSubscription } from "@trigger.dev/core/v3/workers"; |
| 3 | +import { afterAll, beforeAll, describe, expect, it } from "vitest"; |
| 4 | +import { |
| 5 | + seedEngineFixtures, |
| 6 | + workerHeaders, |
| 7 | + type EngineFixtures, |
| 8 | +} from "../../test/bench/lib/engineFixtures"; |
| 9 | + |
| 10 | +const LEGACY_MASTER_QUEUE = "my workers"; |
| 11 | +const subscription: WorkerQueueSubscription = { |
| 12 | + class: "ondemand", |
| 13 | + phase: "fresh", |
| 14 | + compat: "container", |
| 15 | + channel: "stable", |
| 16 | +}; |
| 17 | + |
| 18 | +type Ctx = { server: TestServer; fixtures: EngineFixtures }; |
| 19 | + |
| 20 | +async function startServer(workerGroupId: string, check: string): Promise<Ctx> { |
| 21 | + const server = await startTestServer({ |
| 22 | + extraEnv: { |
| 23 | + RUN_ENGINE_WORKER_QUEUE_SUBSCRIPTIONS: JSON.stringify({ [workerGroupId]: [subscription] }), |
| 24 | + RUN_ENGINE_DUPLICATE_ATTEMPT_START_CHECK: check, |
| 25 | + }, |
| 26 | + overrideEnv: { RUN_ENGINE_WORKER_ENABLED: "1" }, |
| 27 | + }); |
| 28 | + const fixtures = await seedEngineFixtures(server.prisma, { |
| 29 | + taskCount: 1, |
| 30 | + workerGroupId, |
| 31 | + masterQueue: LEGACY_MASTER_QUEUE, |
| 32 | + enableFastPath: true, |
| 33 | + }); |
| 34 | + return { server, fixtures }; |
| 35 | +} |
| 36 | + |
| 37 | +function workerCall(ctx: Ctx, path: string, body: unknown = {}) { |
| 38 | + return ctx.server.webapp.fetch(path, { |
| 39 | + method: "POST", |
| 40 | + headers: { |
| 41 | + ...(workerHeaders(ctx.fixtures, "supervisor-1") as Record<string, string>), |
| 42 | + "x-trigger-worker-runner-id": "runner-1", |
| 43 | + }, |
| 44 | + body: JSON.stringify(body), |
| 45 | + }); |
| 46 | +} |
| 47 | + |
| 48 | +async function triggerAndDequeue(ctx: Ctx) { |
| 49 | + const res = await ctx.server.webapp.fetch( |
| 50 | + `/api/v1/tasks/${ctx.fixtures.taskIdentifiers[0]!}/trigger`, |
| 51 | + { |
| 52 | + method: "POST", |
| 53 | + headers: { |
| 54 | + Authorization: `Bearer ${ctx.fixtures.environmentApiKey}`, |
| 55 | + "content-type": "application/json", |
| 56 | + }, |
| 57 | + body: JSON.stringify({ payload: {} }), |
| 58 | + } |
| 59 | + ); |
| 60 | + expect(res.ok).toBe(true); |
| 61 | + |
| 62 | + for (let i = 0; i < 40; i++) { |
| 63 | + const dequeued = await workerCall(ctx, "/engine/v1/worker-actions/dequeue"); |
| 64 | + const messages = (await dequeued.json()) as any[]; |
| 65 | + if (messages.length > 0) { |
| 66 | + return { |
| 67 | + run: messages[0].run.friendlyId as string, |
| 68 | + snapshot: messages[0].snapshot.friendlyId as string, |
| 69 | + }; |
| 70 | + } |
| 71 | + await new Promise((r) => setTimeout(r, 500)); |
| 72 | + } |
| 73 | + throw new Error("dequeue returned nothing"); |
| 74 | +} |
| 75 | + |
| 76 | +const runPath = (run: string, rest: string) => `/engine/v1/worker-actions/runs/${run}/${rest}`; |
| 77 | + |
| 78 | +function start(ctx: Ctx, run: string, snapshot: string) { |
| 79 | + return workerCall(ctx, runPath(run, `snapshots/${snapshot}/attempts/start`)); |
| 80 | +} |
| 81 | + |
| 82 | +describe("attempt start on a run already executing, enforced", () => { |
| 83 | + let ctx: Ctx; |
| 84 | + |
| 85 | + beforeAll(async () => { |
| 86 | + ctx = await startServer("duplicate-start-enforce", "enforce"); |
| 87 | + }, 300_000); |
| 88 | + |
| 89 | + afterAll(async () => { |
| 90 | + await ctx?.server.stop(); |
| 91 | + }, 120_000); |
| 92 | + |
| 93 | + it("refuses a second start while the first attempt is executing", async () => { |
| 94 | + const { run, snapshot } = await triggerAndDequeue(ctx); |
| 95 | + const first = (await (await start(ctx, run, snapshot)).json()) as any; |
| 96 | + expect(first.snapshot.executionStatus).toBe("EXECUTING"); |
| 97 | + |
| 98 | + const second = await start(ctx, run, first.snapshot.friendlyId); |
| 99 | + expect(second.status).toBe(409); |
| 100 | + const body = (await second.json()) as Record<string, unknown>; |
| 101 | + expect(Object.keys(body)).toEqual(["error"]); |
| 102 | + }, 120_000); |
| 103 | + |
| 104 | + it("starts the next attempt after an immediate retry", async () => { |
| 105 | + const { run, snapshot } = await triggerAndDequeue(ctx); |
| 106 | + // The fixture task allows one attempt. |
| 107 | + await ctx.server.prisma.taskRun.update({ |
| 108 | + where: { friendlyId: run }, |
| 109 | + data: { maxAttempts: 3 }, |
| 110 | + }); |
| 111 | + const first = (await (await start(ctx, run, snapshot)).json()) as any; |
| 112 | + |
| 113 | + const completed = await workerCall( |
| 114 | + ctx, |
| 115 | + runPath(run, `snapshots/${first.snapshot.friendlyId}/attempts/complete`), |
| 116 | + { |
| 117 | + completion: { |
| 118 | + ok: false, |
| 119 | + id: run, |
| 120 | + error: { type: "BUILT_IN_ERROR", name: "Error", message: "boom", stackTrace: "" }, |
| 121 | + retry: { timestamp: Date.now(), delay: 0 }, |
| 122 | + }, |
| 123 | + } |
| 124 | + ); |
| 125 | + expect(completed.status).toBe(200); |
| 126 | + const result = ((await completed.json()) as any).result; |
| 127 | + expect(result.attemptStatus).toBe("RETRY_IMMEDIATELY"); |
| 128 | + |
| 129 | + const retried = await start(ctx, run, result.snapshot.friendlyId); |
| 130 | + expect(retried.status).toBe(200); |
| 131 | + expect(((await retried.json()) as any).run.attemptNumber).toBe(2); |
| 132 | + }, 120_000); |
| 133 | +}); |
| 134 | + |
| 135 | +describe("attempt start on a run already executing, logged", () => { |
| 136 | + let ctx: Ctx; |
| 137 | + |
| 138 | + beforeAll(async () => { |
| 139 | + ctx = await startServer("duplicate-start-log", "log"); |
| 140 | + }, 300_000); |
| 141 | + |
| 142 | + afterAll(async () => { |
| 143 | + await ctx?.server.stop(); |
| 144 | + }, 120_000); |
| 145 | + |
| 146 | + it("allows a second start, as before", async () => { |
| 147 | + const { run, snapshot } = await triggerAndDequeue(ctx); |
| 148 | + const first = (await (await start(ctx, run, snapshot)).json()) as any; |
| 149 | + |
| 150 | + const second = await start(ctx, run, first.snapshot.friendlyId); |
| 151 | + expect(second.status).toBe(200); |
| 152 | + expect(((await second.json()) as any).run.attemptNumber).toBe(2); |
| 153 | + }, 120_000); |
| 154 | +}); |
0 commit comments