tsp-openapi3 - unescaped keyword "init" in union field

[Joseph Price (joprice)]

When generating typespec from an openapi schema, with a component definition like

 "ComposerStep": {
          "oneOf": [
            {
              "$ref": "#/components/schemas/ComposerStepInit"
            },
            {
              "$ref": "#/components/schemas/ComposerStepContinue"
            },
            {
              "$ref": "#/components/schemas/ComposerStepSuggestions"
            }
          ],
          "discriminator": {
            "propertyName": "tag",
            "mapping": {
              "init": "#/components/schemas/ComposerStepInit",
              "continue": "#/components/schemas/ComposerStepContinue",
              "suggestions": "#/components/schemas/ComposerStepSuggestions"
            }
          }
        }

The union case name "init" is not escaped with backticks, resulting in a syntax error:

@discriminated(#{ envelope: "none", discriminatorPropertyName: "tag" })
@oneOf
union ComposerStep {    
  init: ComposerStepInit
  continue: ComposerStepContinue
  suggestions: ComposerStepSuggestions
}

I found a test checking for keyword escapes, but perhaps it's not hitting this node in the ast, or "init" is not included in the reserved word list.

[Timothee Guerin (timotheeguerin)]

Yeah looks like a bug, converted to an issue #7724

[Joseph Price (joprice)]

Thanks! To avoid creating a new discussion you'll have to cleanup, I'll post another one here where I'm unsure if this is expected.

The input schema has

 "progress": {
            "format": "int32",
            "type": "integer"
}

but this results in the typespec scalar Progress extends numeric, which loses the format. I tested this with "number" and "integer" just to be sure.

[Timothee Guerin (timotheeguerin)]

hhm just tried this spec in the playground import and it worked fine

openapi: 3.0.0
info:
  title: (title)
  version: 0.0.0
tags: []
paths: {}
components:
  schemas:
    Test:
      type: object
      required:
        - progress
      properties:
        progress:
          type: integer
          format: int32

[Joseph Price (joprice)]

Odd. I had to manually fix around 20 of those in different positions - schemas, queries, paths, so not sure what's different with your example. I'll update if I can narrow it down.