Support HTTP(S) redirect #34

Activity

1. brunoos commented on Mar 12, 2015

   

   brunoos

   on Mar 12, 2015

   Member

   More actions

   It is not easy without import more code from LuaSocket.

   LuaSec use the "create" parameter on http.request(). The problem is: "create" does not inform if you will connect with a host using http or https.

   If you connect to a host using https and you receive a redirect "http://...", it will break, because LuaSec's "create" only create ssl/tls connections.

   https://github.com/diegonehab/luasocket/blob/master/src/http.lua#L109

   In order to work, LuaSocket must give more information to "create" as parameter, or LuaSec import the code that detects redirect from LuaSocket.

   https://github.com/diegonehab/luasocket/blob/master/src/http.lua#L320
2. mkottman commented on Mar 12, 2015

   

   mkottman

   on Mar 12, 2015

   More actions

   Music Man almost forgot escape go back to you in a 51
   On Mar 12, 2015 9:47 PM, "Bruno Silvestre" notifications@github.com wrote:

   It is not easy without import more code from LuaSocket.

   LuaSec use the "create" parameter on http.request(). The problem is:
   "create" does not inform if you will connect with a host using http or
   https.

   If you connect to a host using https and you receive a redirect "http://...",
   it will break, because LuaSec's "create" only create ssl/tls connections.

   https://github.com/diegonehab/luasocket/blob/master/src/http.lua#L109

   In order to work, LuaSocket must give more information to "create" as
   parameter, or LuaSec import the code that detects redirect from LuaSocket.

   https://github.com/diegonehab/luasocket/blob/master/src/http.lua#L320

   —
   Reply to this email directly or view it on GitHub
   #34 (comment).
3. Tieske commented on Mar 13, 2015

   

   Tieske

   on Mar 13, 2015

   Member

   More actions

   Coding the solution isn't the biggest problem I think. My concerns are about redirects that reduce security. I think that a redirect from https://... to http://... should not be allowed.

   I don't know security that well, but I can also imagine a redirect that still is https://..., but has a lesser level of security, flawed algorithm, or lesser bits encryption, should also not be allowed. Or at least controllable by the user.
4. Tieske commented on Mar 13, 2015

   

   Tieske

   on Mar 13, 2015

   Member

   More actions

   See lunarmodules/luasocket#133 for a fix to allow redirecting over protocols.
5. yagop commented on Mar 13, 2015

   

   yagop

   on Mar 13, 2015

   Author

   More actions

   I was asking for https:// -> https:// redirections. Not https:// -> http:// which I think isn't a normal behaviour for servers.
6. Tieske commented on Mar 13, 2015

   

   Tieske

   on Mar 13, 2015

   Member

   More actions

   The other way around is certainly normal. Anyway, one needs to have them covered.

   But as it currently is, the code should allow for redirects https -> https. Did you test before posting this issue?
7. yagop

   changed the title [-]Support HTTP redirect[/-] [+]Support HTTP(S) redirect[/+] on Mar 14, 2015
8. yagop commented on Mar 14, 2015

   

   yagop

   on Mar 14, 2015

   Author

   More actions

   This is my simple example:

   https = require "ssl.https"
   
   function show_html(url)
   
     local response, code, headers, status = https.request(url)
   
     if code ~= 200 then
       print ("Response :", response)
       print ("HTTP Code :", code)
       print ("Headers :", headers)
       print ("Status :", status)
       return nil 
     end
   
     print(response)
   end
   
   show_html("https://goo.gl/UBCUc5")

   Get wrong version number as code.

   And this is one with options as param:

   https = require "ssl.https"
   ltn12 = require "ltn12"
   
   function download_to_file(url, file_path)
     print("url to download: "..url)
   
     local respbody = {}
     local options = {
       url = url,
       sink = ltn12.sink.table(respbody),
       redirect = false
     }
   
     local response = nil
     response = {https.request(options)}
   
     -- nil, code, headers, status
     local code = response[2]
     local headers = response[3]
     local status = response[4]
   
     if code ~= 200 then
       print ("HTTP Code :", code)
       print ("Headers :", headers)
       print ("Status :", status)
       return nil 
     end
   
     print("Saved to: "..file_path)
   
     file = io.open(file_path, "w+")
     file:write(table.concat(respbody))
     file:close()
   
     return file_path
   end
   
   download_to_file("https://goo.gl/UBCUc5", "/tmp/test.html")

   code is 301, the good part is I can implement the redirection by my own, but it would be nice if the lib do the magic.
9. Tieske commented on Mar 15, 2015

   

   Tieske

   on Mar 15, 2015

   Member

   More actions

   I can confirm the problem (after testing the simple example). But it is not related to the problem I identified in #35.

   Internally the same create function is used twice, and it uses the same table with ssl parameters for creating the context etc.. But the second one fails with an internal LuaSec error; wrong version number. For all I can see this very much looks like a bug... maybe @brunoos can shed some light on this.
10. Tieske commented on Mar 23, 2015

    

    Tieske

    on Mar 23, 2015

    Member

    More actions

    Finally had some time to sort this one out. The problem was not with LuaSec. The redirect url, doesn't have a port number. So the default LuaSocket behaviour is to insert port 80. Which obviously fails with a https call.

    I think this can be closed in favour of #38.
11. yagop

    closed this as completedon Mar 23, 2015
12. yagop commented on Mar 23, 2015

    

    yagop

    on Mar 23, 2015

    Author

    More actions

    Thanks, great job. 👍