Skip to content

http redirects are silently allowed #35

Closed
#36
Closed
http redirects are silently allowed#35
#36

Description

@Tieske
Tieske
opened on Mar 8, 2015

See these lines; https://github.com/brunoos/luasec/blob/1ab6fac9197b194ea94166dff7ad81579f6113ed/src/https.lua#L122-L123

LuaSocket http module blocks redirects only if url.redirect is explicitly set to false. Hence the test here, allows nil to pass and makes LuaSocket execute the redirect.

Activity

  1. Tieske
    added a commit that references this issue on Mar 8, 2015

    fix silently redirecting

    dce7073

  2. brunoos commented on Mar 12, 2015

    @brunoos
    brunoos
    on Mar 12, 2015
    Member

    Since LuaSec does not support redirects, would it be better to keep as it is now?

    And, when we solve the redirect problem in LuaSec, do we adopt the same semantics as LuaSocket?

  3. Tieske commented on Mar 14, 2015

    @Tieske
    Tieske
    on Mar 14, 2015
    MemberAuthor

    Let's close this in favour of the discussion in #34

  4. Tieske
    closed this as completedon Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions