Repository navigation
Use the 0.4 OpenAPI model packages - #79
Merged
Merged
Conversation
Change the model package compat to 0.3 and pin InfrastructureSystems to jd/sdk-0.3. Rename IC.XYCoords to IC.TwoDimensionalFunctionPoint. Schema 0.3.0 stores the DC current fields in kA. set_value! converts the PSS/E values from A. The pm dict now keeps the IMAX limits in kA, so the PTI_INF value means 9999 kA, the "no limit" value of the schema. Update the tests that expected values in A.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
# Conflicts: # src/pm_io/psse.jl # test/test_openapi_dc_shunt.jl # test/test_openapi_transformer_discriminators.jl
annacasavant
approved these changes
Nov 2, 2026
Set the compat of the model packages to 0.4.
jd-lara
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves PowerFlowFileParser to the OpenAPI model packages 0.4, which are built from SiennaSchemas v0.4.0. It sets the model compat to 0.4, pins InfrastructureSystems to the jd/sdk-0.3 branch (InfrastructureSystems.jl#665), and renames IC.XYCoords to IC.TwoDimensionalFunctionPoint. Schema 0.3.0 stores the DC current fields in kA, and set_value! converts the PSS/E values from A, so the parser code for those fields does not change. The pm dict keeps the IMAX limits in kA, so the PTI_INF value of 9999 means 9999 kA, the "no limit" value of the schema.
0.4.0 does not change any source file here, because the parser uses no timestamp field.
Tests: julia --project=test test/runtests.jl gives 3417 passed and 0 failed.